Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configurable by default langserve side #219

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Enable configurable by default langserve side #219

merged 3 commits into from
Nov 13, 2023

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Nov 13, 2023 •
edited
Loading

  • Enable configurable key by default
  • Should be safe to enable by default since the user is already marking the runnable as configurable (when they make it configurable)
  • Raise an client side error if the client specifies a configurable key but the server does not accept it (will help in debugging)

@cla-bot cla-bot bot added the cla-signed label Nov 13, 2023
jakerachleff
jakerachleff approved these changes Nov 13, 2023
View reviewed changes
langserve/server.py Outdated
if "configurable" not in keys:
raise HTTPException(
422,
"Server code has modified the default accepted config keys to "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - should we say something like:

setting configurable fields is disallowed by the server

efriis
efriis approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Nit on the arg naming (keys + config) for someone not as in the weeds. Maybe rename keys to config_keys to relate to the add_routes param, and a comment or rename on configs showing that those are actually the configs from the request.

@eyurtsev eyurtsev merged commit d591be4 into main Nov 13, 2023
10 checks passed
@eyurtsev eyurtsev deleted the eugene/configurable_keys branch November 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

@jakerachleff jakerachleff jakerachleff approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyurtsev @jakerachleff @efriis